Closed
Conversation
Pei-Cheng-Yu
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
Member
|
see this -> #56920 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY:
related: #53051
According to #56920, we need a run_id_pattern filter for TI and we haven't yet
Task Instances should support run_id_pattern filtering, similar to how we added pattern filters for pool, queue, and operator.
Currently, run_id only supports exact search, not pattern matching
This PR adds backend support for run_id_pattern so the UI can correctly use a pattern-based filter instead of requiring the full run_id.
HOW:
The new unit tests are based on existing tests for other filters controlled inside
create_task_instances(e.g.,version_number).I followed the same structure to keep the behavior consistent across all pattern filters.
So the
expected_tiis set according to the outcome that is fixed bycreate_task_instancesmethod^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.